search

val-iisc / expresso

expresso
Other
44 stars 14 forks source link

Updated for Opencv #1

Open prassanna-ravishankar opened 9 years ago

crazymuse commented 9 years ago

Sure, will merge suggested changes asap . . .

prassanna-ravishankar commented 9 years ago

I'd suggest to merge this with a new branch, as I've removed the PIL dependency (because I never can get PIL to work right on my PC) and switched it to OpenCV. However, there might be many other users who do not have opencv python, and for them PIL is better.

I have also changed the way caffe_pb2 is imported. That might be a useful commit into your master branch.

crazymuse commented 9 years ago

Thanks for bringing up this issue. Currently there are few more changes which we are working on. In that merge(which is coming up in a very small time frame), we will consider your suggestion.

prassanna-ravishankar commented 9 years ago

Whenever so, if you find it easy to copy paste the changes vs merging the changes, please feel free to do so and kill this request.

crazymuse commented 9 years ago

I tried out your pull request locally on fresh system. It was giving an error, saying that opencv is not installed.(expected). Furthermore, python opencv may have some conflicts due to anaconda, on some systems. Therefore, we need to update the install.sh and installation instructions, followed by testing on a fresh machine from scratch. Will try to add your pull soon, after necessary testing.