search

vala-lang / vala-language-server

Code Intelligence for Vala & Genie
GNU Lesser General Public License v2.1
290 stars 43 forks source link

VLS should exit after a while if it receives no request #266

Closed JCWasmx86 closed 1 year ago

JCWasmx86 commented 2 years ago

Sadly current (43.0) GNOME-Builder has the problem, that sometimes language servers are not stopped and still run after Builder is closed.

As long as this is happening, there should be e.g. a timeout of 60 minutes. If no request was received it should simply shutdown.

An example:

Screenshot from 2022-09-22 19-48-38

There were 12 instances of VLS running each consuming around 1.2GB RAM. This is a lot of used RAM that makes everything else laggy.

It would be just a temporary fix until this is fixed

Prince781 commented 1 year ago

I'd lean towards "this should be solved upstream", but if the workaround is simple and won't affect other language clients, then I'll support it.

First we have to see if GNOME Builder sends its info in the InitializeParams

JCWasmx86 commented 1 year ago

Ah well, I entirely forgot this issue. This issue is no longer relevant, as I can't reproduce it anymore on GNOME-Builder