search

vala-lang / vala-language-server

Code Intelligence for Vala & Genie
GNU Lesser General Public License v2.1
290 stars 43 forks source link

Criticals from libvala #274

Open lw64 opened 1 year ago

lw64 commented 1 year ago

While using vls very often criticals appear on stderr. This should be avoided.

sonnyp commented 1 year ago

For some context:

@lw64 added support for vala-language-server in Workbench :partying_face: https://github.com/sonnyp/Workbench/pull/156

Workbench has a terminal in readonly mode for debugging. We used to show language servers stderr in there to help with user reports.

We had to stop because vls emit tons of criticals.

image

Prince781 commented 1 year ago

These are criticals in libvala (notice the vala-CRITICAL), not VLS, which uses the vls namespace. So an upstream issue

@ricotz can chime in. I had a PR that would address some of this problem. IIRC most of these are from Vala.GirParser which gets called when we're building documentation for the first time.

sonnyp commented 1 year ago

FYI - Blueprint language server is also very verbose on stderr so I decided to stop displaying it to users.