search

vala-lang / valdo

Create new Vala projects from templates
GNU Lesser General Public License v2.1
52 stars 14 forks source link

elementary OS 7 App Template #26

Open colinkiama opened 1 year ago

colinkiama commented 1 year ago

An elementary OS 7 app template that follows best practices from elementary.

Prince781 commented 1 year ago

Perhaps we should rename the old template to eos6 and make this the default.

colinkiama commented 1 year ago

Oh yeah, that makes sense. This would be similar to what happens with the gtk and gtk3 templates.

Should I make this change myself?

Prince781 commented 1 year ago

Should I make this change myself?

Yeah, go ahead

colinkiama commented 1 year ago

The elementary OS templates have been renamed now

colinkiama commented 1 year ago

I've noticed an issue with libadwaita styling not being overridden with elementary styling when building and running the flatpak through GNOME Builder.

Here's what the app looks like when running it from GNOME Builder: image

However, this is what the app looks like when running it using VS Code's Flatpak extension (Note: I am using the non-flatpak version of VS Code): image

This is the expected behaviour. The flatpak also has elementary styling after installing it using the flatpak and flatpak-builder cli commands.

I'm not sure what's causing this issue. I suspect that it has something to do with GNOME Builder.

Prince781 commented 1 year ago

@colinkiama I just wrapped up a bunch of merge requests. You'll have to rebase (git pull --rebase origin master)

colinkiama commented 1 year ago

I decided to drop libadwaita from the template. The issue with GNOME Builder is now fixed. This is ready to be merged now.

Prince781 commented 1 year ago

I don't remember why we included libadwaita in the template. Was it ever a part of the elementary SDK?

colinkiama commented 1 year ago

elementary has been relying on libhandy a lot for gestures and some of the widgets it comes with.

I assumed that it would be just as easy to include libadwaita as it's supposed to be the successor for libhandy for GTK 4 apps. It turns out, it's not as easy as it seems.

Libadwaita is not in the elementary-sdk package but it is available in the elementary flatpak platform package.

colinkiama commented 11 months ago

Hi, just following up on this PR

colinkiama commented 11 months ago

@Prince781 👋

darltrash commented 3 weeks ago

oh lol I just made a PR for the same thing, guess i should've read the existing PRs