valadaptive / ntsc-rs

Free, open-source analog TV + VHS effect. Standalone application + plugin (After Effects, Premiere, and OpenFX).
Other
241 stars 4 forks source link

video encoded with lagarith codec do not play + some nitpicks #12

Open nlolnlolnlolnlo opened 6 months ago

nlolnlolnlolnlo commented 6 months ago

ntsc-rs-standalone_L1DjXsyNOf videos encoded with the lagarith lossless codec do not play, i use lagarith to capture raw analog video so it's kinda inconvenient to have to reencode every time i want to pass some footage thru

the nitpicks: -would it be possible to add an option to select other codecs than just ffv1 and h264? -the tracking noise filter has a function called wave that jitters each line individually, would it be possible to add this to the entire image on a reduced intensity in the vhs emulation category? the current edge wave function looks fine at a small scale but when attempting to replicate something like extended play vhs or heavy generation loss it's not nearly enough to look convincing. in my tests i think this is the biggest thing that makes it obvious the end result is just a filter and not actually vhs -is it possible to auto-refresh the preview when a new preset is loaded? it's annoying having to reshuffle the seed every time

everything i've encountered here is in the standalone windows build of ntsc-rs

valadaptive commented 6 months ago
nlolnlolnlolnlo commented 6 months ago

the container format is avi, exported from virtualdub. i have a sample clip that i can upload to gdrive or something if it's wanted.

i'd say definitely huffyuv and lagarith since those are time-tested codecs for analog-based stuff, maybe h.265 for slightly better filesizes?

valadaptive commented 6 months ago

It looks like, while GStreamer does have a Lagarith codec, its demuxers don't recognize its fourcc code so it never actually uses that codec. A sample clip would be helpful--I can try to get a fix upstreamed to GStreamer, but it might take a while to make its way to their next release.

I haven't added any new output codecs yet--does ffv1 cause any issues or produce larger files than Lagarith or HuffYUV? I may add HuffYUV if it's better than ffv1, but neither FFmpeg nor GStreamer include a Lagarith encoder so I unfortunately can't support that.

In the latest release, I have fixed the bug where the preview doesn't refresh, and added more parameters to the "edge wave" setting to hopefully improve its realism and flexibility. Let me know how well it works.

nlolnlolnlolnlo commented 6 months ago

preview fixes & edge wave settings work wonderfully! huffyuv is more compatible with older software where ffv1 isn't supported (a notable example is magix vegas which completely refuses ffv1 from my testing),

sad to hear that lagarith isn't possible at the moment :( for whatever it's worth, here's a small test clip. https://drive.google.com/file/d/1V5jwS1kA0LSJLSvVHW2FLwv1fkCDBhm2/view?usp=sharing

thank you for being so communicative!! this filter has really been a game changer for me, it's so nice to be able to quickly throw stuff into this and see how it would look immediately without having to waste space on actual tape lol

valadaptive commented 1 month ago

Reopening this: the upstream GStreamer merge request for Lagarith codec recognition is https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6831. I'll close this again once it's merged and the next GStreamer release includes it.