valadaptive / ntsc-rs

Free, open-source analog TV + VHS effect. Standalone application + plugin (After Effects, Premiere, and OpenFX).
Other
237 stars 4 forks source link

fix: replace match with explicit if-else #125

Closed alexlnkp closed 2 days ago

alexlnkp commented 3 days ago

this fixes warnings of float not being supported in pattern-matching

although this is uglier than the original, it produces no warnings during build

valadaptive commented 2 days ago

There was actually an explicit #[allow(...)] here before, but Rust actually removed the lint warning in more recent versions.

alexlnkp commented 2 days ago

There was actually an explicit #[allow(...)] here before, but Rust actually removed the lint warning in more recent versions.

So... uhh.. What would be the best solution then?

valadaptive commented 2 days ago

Update your Rust version (probably via rustup).

alexlnkp commented 2 days ago

Update your Rust version (probably via rustup).

Yeah, that worked. Sorry, I'm just more used to package managers doing all the work for me lol