valadaptive / ntsc-rs

Free, open-source analog TV + VHS effect. Standalone application + plugin (After Effects, Premiere, and OpenFX).
Other
355 stars 7 forks source link

OFX version issue: "checkerboards" in color bleed/offsets #13

Closed Lu9-ST closed 9 months ago

Lu9-ST commented 9 months ago

Maybe it is an issue with the OFX version or maybe specifically VEGAS Pro which is what I'm using, can't quite tell. But I was trying out the plugin on VEGAS and at least on preview (with the preview quality set to the best one) it looks exactly as I expect, nothing wrong here. But if I render the video out, or even just copy a frame of the video or save a frame to an image (buttons that are in the preview panel) there will be this pretty weird artifact that I'm not sure what it is - here is a close-up on it: image I thought it perhaps has something to do with the alpha channel but that doesn't make a lot of sense. Maybe there is a setting in vegas itself that I don't know about that I could change that would fix this, but for now I'll just ask about it in case any of you might know what the issue is.

Also: dunno if this is something you could even fix, but if video preview is set to lower resolutions (i.e. "Good (Auto)" or "Preview (Quarter)") that also affects the effect in the preview, so to get an actual preview of how the end result will look like I have to temporarily switch video preview to full resolution ("Good (Full)" or "Best (Full)") which isn't the worst thing ever or makes it unusable, but it Would be nice if the effect preview stayed a bit consistent

valadaptive commented 9 months ago

The checkerboard pattern is intentional--it's an NTSC/VHS artifact called "dot crawl". You may be able to change (but not eliminate) the pattern by changing the "Chroma demodulation filter" to "1-line comb" or "2-line comb". It's inherent to the way NTSC video works.

Regarding the video preview, I don't think I can fix that. Vegas gives the plugin a low-resolution image to work with, and the plugin gives a low-resolution image back.

Lu9-ST commented 9 months ago

ah, I thought it wasn't the dot crawl because of how... uniform and "perfectly checkered" it looks, but good to know. also just checked that it also happens on the standalone version, so maybe i just didn't notice it much with other videos i've tested it with