valadaptive / ntsc-rs

Free, open-source analog TV + VHS effect. Standalone application + plugin (After Effects, Premiere, and OpenFX).
Other
355 stars 7 forks source link

(issue) dot crawl artifacts render at half speed? #33

Closed nlolnlolnlolnlo closed 7 months ago

nlolnlolnlolnlo commented 8 months ago

whenever i render out a sequence in ntsc-rs at 29.97 frames per second, the dot crawl seems to render at half of that and instead updates after two frames, slower than any other element. this causes some particularly nasty issues when rendering to 29.97i where it causes odd artifacts. is this intentional, and is there a way to fix it if not?

for some visual reference, here's a small comparison between real cvbs and ntsc-rs. i've looped two conseceutive frames from both sources. notice how the (exaggerated) composite noise moves between the two frames but the dot crawl doesn't on the ntsc-rs example?

real composite: ezgif-3-29546ca4ac ntsc-rs: ezgif-3-56f41497e8

as always, feel free to reach out if you want my source files/clarification on anything.

Degamisu commented 8 months ago

Could I see your settings?

nlolnlolnlolnlo commented 8 months ago

cvbs.json ntsc_rs_dotcrawl_testpattern

Degamisu commented 8 months ago

Great, Thanks!


I tried out your settings and I also noticed your issue.

I ran the picture myself with my own settings and the result was successful. This helped measure the dotcrawl:composite noise rate.

image

For the settings, I used DC.json. Give these a try with the image and see if it fixes your problem.

https://github.com/valadaptive/ntsc-rs/assets/149022474/dae3e53d-30aa-4106-a655-8ab8a1c791a1

nlolnlolnlolnlo commented 8 months ago

this doesn't fix the problem - at least not for my usecase. the option "alternating" bobs the fields which messes up interlaced footage

valadaptive commented 7 months ago

This is still an issue with the "Use field" -> "Both" setting, but the new "Interleaved" setting should fix this.