#359 General improvements lighthouse testing - Githubissues

valantic / vue-template

A custom Vue.js boilerplate based on webpack.

MIT License

8 stars 4 forks source link

#359 General improvements lighthouse testing #365

Closed BeneRichi closed 6 months ago

BeneRichi commented 9 months ago

Pull request

Improves Lighthouse test. Adds role on li element in ul list.

Ticket

https://github.com/valantic/vue-template/issues/359

Browser testing

http://localhost:5173/styleguide/

Checklist

[ ] I merged the current development branch (before testing)
[ ] Added JSDoc and styleguide demo
[ ] Tested all links in project relevant browsers
[ ] Tested all links in different screen sizes
[ ] Did run automated tests and linters
[ ] Did assign ticket
[ ] Double checked target branch

Review/Test checklist

[ ] Did review code and documentation
[ ] Tested all links in project relevant browsers
[ ] Tested all links in different screen sizes
[ ] Did check accessibility (Wave, only errors)
[ ] Re-assign ticket to developer