search

valarao / chocolate-thunder-chess

Allow chess players to search through 1,000+ common opening positions.
MIT License
2 stars 2 forks source link

Add search functionality #71

Closed austincho closed 3 years ago

austincho commented 3 years ago

Overview

The changes in this PR connects the backend /search endpoint with the redux data store in the front end and allows for the ability to search for positions using the search bar. Resolves #42 and unblocks #43.

We likely want to implement a loading spinner while we wait for the response from the backend. My plan is to work on the loading spinner when I work on the paginations for searches that result in over 9 positions (#43).

austincho commented 3 years ago

Great work, Austin - left a few comments.

Also, I noted a potential backend issue: When I try to search "defense", nothing shows up (even though a lot of openings start with defense). In addition to addressing my comments, can you double check the searching algorithm?

Thanks and let me know if you have any questions!

Hey Miguel, currently when the search happens it looks if the baseOpening.name field or the variation field contains what you searched. I believe the issue that you're running into is because of the fact that the our data uses the "Defence" spelling vs "Defense".