valb3r / flowable-bpmn-intellij-plugin

Flowable, Activiti, Camunda BPMN engines process editor plugin for IntelliJ. Pure Kotlin (and some Java)
https://plugins.jetbrains.com/plugin/14318-flowable-bpmn-visualizer
MIT License
157 stars 31 forks source link

Support for jBPMN dialect #308

Open valb3r opened 2 years ago

valb3r commented 2 years ago

Is your feature request related to a problem? Please describe. Add support for jBPMN dialect. See https://github.com/valb3r/flowable-bpmn-intellij-plugin/issues/299#issuecomment-1004832481 for example

Damounet commented 2 years ago

Nice, I'd be glad to help you or test anything if you need.

valb3r commented 2 years ago

@Damounet If you are willing to help, you can have a look at https://github.com/valb3r/flowable-bpmn-intellij-plugin/tree/master/activiti-xml-parser - it is an example of what needs to be implemented to parse jBPMN files. Basically, it would be great if you provide test XML files like the ones here: https://github.com/valb3r/flowable-bpmn-intellij-plugin/tree/master/activiti-xml-parser/src/test/resources At least files where:

  1. All elements available in jBPMN modeler are present (example https://github.com/valb3r/flowable-bpmn-intellij-plugin/blob/master/activiti-xml-parser/src/test/resources/popurri.bpmn20.xml)
  2. Per element file with all properties declared (example https://github.com/valb3r/flowable-bpmn-intellij-plugin/blob/master/activiti-xml-parser/src/test/resources/custom-service-tasks/script-task.bpmn20.xml)

With these, it would be clearer what is the amount of work. And they are going to be used to test dialect implementation

Damounet commented 2 years ago

Is this the kind of stuff you are looking to ?

popurri.bpmn.md which is represented like that : Capture d’écran 2022-01-07 à 16 05 04

This file contains all the components I can create. Too achieve that I used this VsCode extension https://marketplace.visualstudio.com/items?itemName=redhat.vscode-extension-bpmn-editor but I haven't found on their repository (https://github.com/kiegroup/kogito-tooling) any test file like the one you are looking for.

If this suits your needs, I'll work on the on file per component next week :)

valb3r commented 2 years ago

@Damounet, thanks

Is this the kind of stuff you are looking to ?

Yes, the only thing the elements need to be connected with sequence flow, as jBPMN seem to use different anchors (center of the rectangle) compared to the current implementation