valb3r / flowable-bpmn-intellij-plugin

Flowable, Activiti, Camunda BPMN engines process editor plugin for IntelliJ. Pure Kotlin (and some Java)
https://plugins.jetbrains.com/plugin/14318-flowable-bpmn-visualizer
MIT License
156 stars 31 forks source link

Expression on sendTask not evaluated. #384

Closed SamTheisens closed 5 months ago

SamTheisens commented 6 months ago

Describe the bug Expression on sendTask is not evaluated.

To Reproduce

  1. Define two identical tasks with an expression, the only difference being that one is serviceTask and the other sendTask

BPMN definition

<?xml version="1.0" encoding="UTF-8" ?>
<diagram xmlns="http://www.omg.com/di/1.0.0">
<bpmn:serviceTask id="ServiceTask"
                  camunda:expression="${dbsDceStatementParsingProcessService.parseCsvAndStoreInEnergyCore(execution)}">
</bpmn:serviceTask>
<bpmn:sendTask id="OtherTask"
                 camunda:expression="${dbsDceStatementParsingProcessService.parseCsvAndStoreInEnergyCore(execution)}">
</bpmn:sendTask>
</diagram>

Expected behavior I expect the expression to be evaluated for both types of tasks

Screenshots Screenshot 2024-02-01 at 21 27 03

IntelliJ version (please complete the following information): IntelliJ IDEA 2023.3.3 (Ultimate Edition) Build #IU-233.14015.106, built on January 25, 2024

Additional context

As a consequence of the fact that sendTask expressions aren't evaluated, find usage isn't exhaustive. Which makes refactoring a lot less safe. Screenshot 2024-02-01 at 21 25 14

SamTheisens commented 5 months ago

@valb3r Thanks for the super quick fix! 🙏 🚀