JOSE Review: Typos, URLs

valdanchev / reproducible-data-science-python

Reproducible Data Science with Python

Other

19 stars 8 forks source link

JOSE Review: Typos, URLs #7

Closed lechten closed 2 years ago

lechten commented 2 years ago

This is related to your JOSE submission.

In Acknowledgements, a closing parenthesis is missing (after “(BITSS)”?).
L. 96, “The resource is designed to scaffold reproducible and transparent research workflow”: Should this be “a” workflow or “workflows”?
The checklist asks for DOIs. Not all papers have one. Did you check? Note that the URL in Lau et al. is not formatted as hyperlink.
The URL in Guzharina is too long. It should be broken, maybe at “-”.

valdanchev commented 2 years ago

Thank you for the helpful comments, which I have addressed:

corrected the typos
added DOIs for almost all papers (except for Hagberg et al which does not seem to be available)
formated the URL in Guzharina to fit

lechten commented 2 years ago

I just tried to generate a new PDF for the JOSE issue, which failed, probably due to the subdirectory. Do you know how to do that?

valdanchev commented 2 years ago

Many thanks! Just renamed the subdirectory to paper, which hopefully solves this; if not, another option would be to place the paper files outside the subdirectory.

lechten commented 2 years ago

Thanks! Now there is a ruby exception...

I have no idea whether this is a general issue or related to your paper.

lechten commented 2 years ago

Actually, that is probably the ":" in the title. Maybe replace with emdash? Or quote somehow?

valdanchev commented 2 years ago

Totally, thanks, added quotes.

lechten commented 2 years ago

Thank you for the update. I asked for the PDF at JOSE...

lechten commented 2 years ago

Thank you for your patience. With the new PDF, everything seems fine to me. Closing this.