valderman / selda

A type-safe, high-level SQL library for Haskell
https://selda.link
MIT License
478 stars 58 forks source link

New Hackage release? #187

Open dhess opened 1 year ago

dhess commented 1 year ago

Hi, thanks for this project!

With the recent support for GHC 9.4.4 and text > 2, it would be helpful if there were a release to Hackage that included these new features. Is that feasible in the near future?

dhess commented 1 year ago

Ideally a new release would include #188, as well.

tomasaschan commented 1 year ago

@dhess You mentioned here that you re-introduced selda in your project. Did that include a patch to support text >2? If so, how did you get that - build this library from source, or install through other means than hackage?

dhess commented 1 year ago

@tomasaschan Here's what we're using:

https://github.com/hackworthltd/primer/blob/9e4d489a050207420669cd9b5bd9efeb40ffee8f/cabal.project#L29

tomasaschan commented 1 year ago

@dhess Thanks a bunch! That seems to work for me too; although I'm using stack, so I put this in my stack.yaml (and added selda and selda-sqlite to my dependencies):

extra-deps:
- git: https://github.com/guibou/selda
  commit: ab9619db13b93867d1a244441bb4de03d3e1dadb
  subdirs:
  - selda
  - selda-sqlite

Worked like a charm (at least for building with the deps included.. 🤞🏻)

seanhess commented 8 months ago

@valderman is selda is abandoned? If not can we get some upper-bounds fixes into a new hackage release? I'm currently blocked by time < 1.12, although the text <2 issue bound to come up soon.

seanhess commented 8 months ago

@dhess are you still using selda? You mentioned above relying on @guibou's fork. Any thoughts on maintaining a fork with upper-bounds fixes?

dhess commented 8 months ago

@seanhess We're still using it, but only until I can port our Selda code to Beam.

guibou commented 8 months ago

We are hosting a selda fork at https://github.com/novadiscovery/selda in branch nova-master which build with GHC 9.8.

Please beware, it contains a few fixs specific to our company that I have no idea what could be the impact on another codebase.

Note also, I realized that our custom builder does manually ignore bounds for some of the sub component (selda-sqlite and selda-postgresql). I can integrate these fix in our fork if you wish.