search

valdezt / sigfig

A python module aimed to aid the user with visual display of scientific numbers, i.e. significant figures, rounding, spacing, etc.
12 stars 4 forks source link

Warning that no number is provided when trying to round zero #4

Open haerfest opened 3 years ago

haerfest commented 3 years ago

With sigfig 1.1.8, when calling round on a zero-value, I get a UserWarning claiming that I did not provide a number to round:

>>> import sigfig
>>> round(0.00, sigfigs=1)
site-packages\sigfig\sigfig.py:432: UserWarning: no number provided, assuming zero (0)
  warn('no number provided, assuming zero (0)')
0.0

Seems to be due to this test in _num_parse:

if not num:
        warn('no number provided, assuming zero (0)')

Should that not be:

if num is None:
        warn('no number provided, assuming zero (0)')