valdisiljuconoks / LocalizationProvider

Database driven localization provider for .NET applications (core assemblies)
https://tech-fellow.eu/
Apache License 2.0
123 stars 41 forks source link

Xliff format parser support for CDataTag and ResourceStringContent #295

Closed paule96 closed 1 month ago

paule96 commented 1 month ago

Currently it was only possible to import CData string in the target language of an XLIFF document. But the XLIFF standard supports both a ResourceStringContent and a CDataTag So we now added support for it.

This PR fixes also:

paule96 commented 1 month ago

@valdisiljuconoks why is the build process running on windows? Is it possible to switch it to linux? That is currently the reason why the tests are failing, because the Windows agent on GitHub only provides docker for windows containers.

If we would switch to linux all the test with test containers would work, but some other tests that checks formats will fail:

I fixed the tests for linux. it was a wrongly encoded file

valdisiljuconoks commented 1 month ago

legacy ;)

paule96 commented 1 month ago

@valdisiljuconoks can you check if the sonar token is still accessible to the pipeline?

image

It seems to be gone. (normally there would be stars if it is set)

Please also check the casing of the variable, because linux is case sensitiv.

Edit:

I can now prove that it is not defined: image

paule96 commented 1 month ago

@valdisiljuconoks can we expect here a fast merge like before? :) Just to know if we need to pull a local fork, to make progress in your solution that will be based on this amazing library / project

valdisiljuconoks commented 1 month ago

sorry for ignorance ;)

I was out hiking few days. Expect review in a few days

valdisiljuconoks commented 1 month ago

sonar build might be failing in PRs as it might not be able to decode repos secrets. will see after merge.