Closed paule96 closed 1 month ago
@valdisiljuconoks why is the build process running on windows? Is it possible to switch it to linux? That is currently the reason why the tests are failing, because the Windows agent on GitHub only provides docker for windows containers.
If we would switch to linux all the test with test containers would work, but some other tests that checks formats will fail:
I fixed the tests for linux. it was a wrongly encoded file
legacy ;)
@valdisiljuconoks can you check if the sonar token is still accessible to the pipeline?
It seems to be gone. (normally there would be stars if it is set)
Please also check the casing of the variable, because linux is case sensitiv.
Edit:
I can now prove that it is not defined:
@valdisiljuconoks can we expect here a fast merge like before? :) Just to know if we need to pull a local fork, to make progress in your solution that will be based on this amazing library / project
sorry for ignorance ;)
I was out hiking few days. Expect review in a few days
sonar build might be failing in PRs as it might not be able to decode repos secrets. will see after merge.
Currently it was only possible to import
CData
string in the target language of an XLIFF document. But the XLIFF standard supports both aResourceStringContent
and aCDataTag
So we now added support for it.This PR fixes also:
Value
of aLocalizationResourceTranslation
will now always contains a string and never null