valdisiljuconoks / localization-provider-opti

Database driven localization provider for Optimizely (ex. Episerver) websites
Apache License 2.0
11 stars 17 forks source link

JsResourceHandler doesn't invalidate cache #4

Closed dvMasiuk closed 6 years ago

dvMasiuk commented 6 years ago

Hi there! It seems JsResourceHandler doesn't remove entries from cache. It uses CacheKeyHelper.GenerateKey to insert entries, but here https://github.com/valdisiljuconoks/localization-provider-epi/blob/master/src/DbLocalizationProvider.EPiServer.JsResourceHandler/JsResourceCacheInvalidationModule.cs#L34 'existingKey' is just a substring of the cache key hence CacheManager cannot remove entries.

valdisiljuconoks commented 6 years ago

good catch

valdisiljuconoks commented 6 years ago

out on nuget feed. wait for 4.3.5