search

valdisiljuconoks / optimizely-advanced-contentarea

Optimizely content area renderer on steroids
Apache License 2.0
34 stars 14 forks source link

Backward compatibillity #27

Closed LucGosso closed 7 years ago

LucGosso commented 7 years ago

Hey Valdis, was runing on version 4.0.1, after upgrading to latest 4.3 make some init modules to fail.

missing objects: DisplayModeFallbackProviderInitModule SwapRendererInitModule RowSupportEnabled AutoAddRow

...For() .Use() .SetProperty(i => i.RowSupportEnabled = false) .SetProperty(i => i.AutoAddRow = false));

Sorry, asking before looking for answers. Stressed

Also is any of this breaking changes?

Regards Luc

valdisiljuconoks commented 7 years ago

Hi Luc,

I'm disaster, totally forgot about SemVersion. I moved this stuff to configuration context. No need to mess around IoC anymore.

Sorry for trouble. Here is link: https://github.com/valdisiljuconoks/EPiBootstrapArea/blob/master/README.md#available-configuration-options

valdisiljuconoks commented 7 years ago

@LucGosso can we close this or we need to bump up version to next major?

valdisiljuconoks commented 7 years ago

@LucGosso can we close this or we need to bump up version to next major?

LucGosso commented 7 years ago

Up to you :)

Yes close

Regards!

22 juni 2017 kl. 23:38 skrev Wałdis Iljuczonok notifications@github.com:

@LucGosso can we close this or we need to bump up version to next major?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

valdisiljuconoks commented 7 years ago

Will jump with next major updates.

RavindraSinghRathore commented 5 years ago

Hi Luc,

I'm disaster, totally forgot about SemVersion. I moved this stuff to configuration context. No need to mess around IoC anymore.

Sorry for trouble. Here is link: https://github.com/valdisiljuconoks/EPiBootstrapArea/blob/master/README.md#available-configuration-options

Hi,

I tried this on 5.2.0.0 version but it still adding the row class on the parent div.

Could you please let me know if I missing something.

Thanks Ravindra