search

valdisiljuconoks / optimizely-advanced-contentarea

Optimizely content area renderer on steroids
Apache License 2.0
34 stars 14 forks source link

Renderer cannot be a singleton Fix #37 #38

Closed Eric-Maddox closed 5 years ago

Eric-Maddox commented 5 years ago

Renderer cannot be a singleton because Render() is called my multiple threads threads. Fix #37

valdisiljuconoks commented 5 years ago

this is very good catch. thought about that couple times but at the end could get enough time to prove its the case.

thanks. will make sure it's merged and released soon.

valdisiljuconoks commented 5 years ago

look for v5.2

Eric-Maddox commented 5 years ago

Thank you for maintaining this add-on. It is very useful.

From: wałdis iljuczonok notifications@github.com Sent: Saturday, February 16, 2019 5:58 AM To: valdisiljuconoks/EPiBootstrapArea Cc: Eric Maddox; Author Subject: Re: [valdisiljuconoks/EPiBootstrapArea] Renderer cannot be a singleton Fix #37 (#38)

look for v5.2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/valdisiljuconoks/EPiBootstrapArea/pull/38#issuecomment-464336389, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALLuR0kQ7t_B4IfviYk9Bpte_dm0-Nqdks5vN-RngaJpZM4a-gS8.