search

vale46n1 / immich_duplicate_finder

A Comprehensive Solution for Identifying and Managing Duplicate Photos in Immich
Apache License 2.0
184 stars 12 forks source link

Cant delete images #16

Closed moxli closed 4 months ago

moxli commented 4 months ago

When I click the delete button on a duplicate the duplicate finder restarts and the duplicate is not deleted.

image

When it finishes each time 1045 duplicates are found.

My Settings: image

There are no log messages displayed after clicking the delete button.

random1planet commented 4 months ago

I have been having the same issue and thought I was missing something, but this still could be the same.

mariosemes commented 4 months ago

I was thinking that I'm going crazy, same thing here. Whatever I do the Index processing restarts and ignores the selected delete.

mariosemes commented 4 months ago

https://github.com/vale46n1/immich_duplicate_finder/assets/2343219/495a74b8-d76d-4619-b77f-ab4aa0ca150b

random1planet commented 4 months ago

There could be something we are missing. I'm not a developer but reasonably technical. I'm assuming there is something I am doing wrong and maybe the app doesn't have the right permissions or something through the API.

On 16 Apr 2024 18:40, TMC @.***> wrote:

https://github.com/vale46n1/immich_duplicate_finder/assets/2343219/495a74b8-d76d-4619-b77f-ab4aa0ca150b

— Reply to this email directly, view it on GitHubhttps://github.com/vale46n1/immich_duplicate_finder/issues/16#issuecomment-2059610085, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN7TILDA4GXUZ5A4J5VROGLY5VO67AVCNFSM6AAAAABGIA6IFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGYYTAMBYGU. You are receiving this because you commented.Message ID: @.***>

vale46n1 commented 4 months ago

Thanks for bringing this to my attention. I'll review the current implementation. I'm also planning to refactor the code and integrate a React frontend, which should enhance the functionality and user experience significantly

random1planet commented 4 months ago

Just say this is an amazing piece of work and like magic to find all the duplicates, it wasnt that difficult to set up after blasting few a through Linux distros. So thanks for your work so far 🙂

vale46n1 commented 4 months ago

I've addressed the bug and have also made significant improvements to our duplicate management system. I have eliminated the need to recreate the vector database each time by saving duplicate pairs and their similarity scores directly in a local SQLite database. This change not only enhances performance by allowing more efficient loading but also supports dynamic identification of duplicates using customizable minimum and maximum similarity thresholds. These adjustments should greatly improve the system's efficiency and reliability