search

vale46n1 / immich_duplicate_finder

A Comprehensive Solution for Identifying and Managing Duplicate Photos in Immich
Apache License 2.0
184 stars 12 forks source link

IsExternal (and IsReadonly) incorrectly displayed #46

Open CristianT opened 2 months ago

CristianT commented 2 months ago

I'm using Main - fcc7a25176e4bad371f20004c8aacd5d239ee04e

IsExternal doesn't work properly and I have trouble to identify the origin of the images to delete. I'm using Immich 1.105.1 and according to this: [https://immich.app/docs/api/get-asset-info/]([https://immich.app/docs/api/get-asset-info/](https://immich.app/docs/api/get-asset-info) IsExternal (and IsReadOnly) have been deprecated.

My proposal would be to infer IsExternal from the property originalPath or at least show the original path in the file comparison.

CristianT commented 2 months ago

Here is a PR that I tested and works for me: https://github.com/vale46n1/immich_duplicate_finder/pull/47