Open lukashermansson opened 3 hours ago
The tests will need to be updated.
This has a test failure(as you also already spotted), don't merge this just yet, will need to get an implementation that does not send a packet to the client when it was the client that updated it! thanks for the quick review!
Objective
Attempts to solve the issue shown in discord https://discord.com/channels/998132822239870997/1292890441011957830 where doing has no effect in a "open inventory"
Looks like an oversight in the system to update the open inventories, no attempt to send any packet to the user was made when the
CursorItem
component was updated by any systemPlayground to reproduce the issue solved by this pr.
Solution
Copied the approach to sync the
CursorItem
state from theupdate_player_inventories
system to theupdate_open_inventories
where it was previously left out (my assumption is that it was left out by mistake).