search

valendesigns / archetype

1 stars 0 forks source link

Jetpack logo doesn't work during live preview #83

Closed whysir closed 9 years ago

valendesigns commented 9 years ago

I think this is an issue with Jetpack itself and needs to be fixed upstream. I've opened an issue with them but I'll keep looking into in the meantime. Not going to spend much time on it though, as there are more important things to do.

The reason I suspect it's Jetpack and not Archetype is that when you remove the jetpack_has_site_logo() from the if statement on header.php#L29 live preview works again. Which makes me think that the issue is that the code never gets executed due to the async nature of that control, leaving the default text in place. I'll see if we can use a different if statement to achieve the desired results, but if the issue is that the control uses 'transport' => 'postMessage' then there is nothing we can do I suppose.

valendesigns commented 9 years ago

This was a complete nightmare, but it's now fixed on our end. As well, the fix has the added benefit of supporting postMessage for the SVG Logo so it's all done instantly without a page reload. I have no idea what changed in Jetpack, but it doesn't matter anymore.