fix: internal cookie storage isn't reset on test teardown

valendres / playwright-msw

A Mock Service Worker API for Playwright

MIT License

166 stars 23 forks source link

fix: internal cookie storage isn't reset on test teardown #30

Closed lesha1201 closed 2 years ago

lesha1201 commented 2 years ago

@valendres I didn't have time to add tests for that and clean everything up so it's a draft for now. I can add them later. You can push changes directly into PR if you want.

valendres commented 2 years ago

Looks good so far! What kinds of tests are you thinking of writing for this?

If it helps, I'm currently working on getting Jest added so that unit tests can be used in addition to the integration tests.

lesha1201 commented 2 years ago

@valendres I was planning just to add/change E2E tests in example folder so it covers that case.

lesha1201 commented 2 years ago

@valendres Sorry, I'm quite busy this week with work so still wasn't able to allocate time for that and I'm not sure I will be able to that on weekend. I would appreciate if you can add the tests. Another option would be to merge it as it is and I will open another PR with tests when I can.

valendres commented 2 years ago

@lesha1201 All good mate, I definitely understand being busy! I'm happy to merge this now. I'll spend some time tomorrow morning to add a couple of tests.