search

valendres / playwright-msw

A Mock Service Worker API for Playwright
MIT License
162 stars 22 forks source link

fix: paths with trailing slash and route/query params not being matched #41

Closed valendres closed 1 year ago

valendres commented 1 year ago

Second attempt at fixing https://github.com/valendres/playwright-msw/issues/38

lesha1201 commented 1 year ago

@valendres When will it be merged? I don't really need it right now but it would be nice to merge. If you're busy then it's ok to postpone it for some more time.

valendres commented 1 year ago

@valendres When will it be merged? I don't really need it right now but it would be nice to merge. If you're busy then it's ok to postpone it for some more time.

@lesha1201 Amusing timing, I was actually just having a look at this now. I finally moved to the US and found some time to look at the library again. I plan to get this merged some time today :)

lesha1201 commented 1 year ago

@valendres Ahah :) Thanks. I hope your move went well.

valendres commented 1 year ago

@lesha1201 It went well, it feels good to finally be here.

On another note, I just published this fix in playwright-msw@2.0.2