search

valendres / playwright-msw

A Mock Service Worker API for Playwright
MIT License
166 stars 23 forks source link

Migrate / support MSW 2 #76

Open the-ult opened 1 year ago

the-ult commented 1 year ago

With the new release of MSW, it would be great if playwright-msw supports it as well.

[edit] Gonne give it a go to provide a PR if I can find some time this week

kettanaito commented 11 months ago

Let me know if you have any questions/need help. Should be rather straightforward. The Migration guide should be all that you need. Thanks for this amazing project!

the-ult commented 11 months ago

Sorry, been crazy busy. Actually gonna give it a new try next week

valendres commented 11 months ago

Hey @the-ult, thanks for the polite nudge to support MSW 2.0. I appreciate the offer for help and completely understand that you've been quite busy. I've started working on the migration and should hopefully have it done this weekend.

@kettanaito Thanks for creating this amazing library and sharing the migration guide. Absolutely love all the examples, it's making this conversion a breeze 🙂

the-ult commented 11 months ago

Thank you @valendres. That's awesome!

valendres commented 11 months ago

@the-ult I've got a PR up for the migration. I'd love to get your review if you have a chance: https://github.com/valendres/playwright-msw/pull/77

valendres commented 11 months ago

Hey everyone, playwright-msw@3.0.0 is now available, bringing compatibility with MSW 2.

A huge thank you goes to @the-ult and @kettanaito for your detailed reviews, and @mamidenn for your initiative in addressing the feedback, as discussed in the corresponding PR. Your efforts have been crucial and are deeply appreciated.

I apologize for the delay in supporting MSW 2. Balancing house moving, renovations, and attending AWS re:INVENT has made my schedule quite tight. But with re:INVENT behind us and the move nearly complete, I’m thrilled to finally have some time to get this release out.

Although all of the integration tests in this repo are passing, the real-world usage is the ultimate test. I’m eager to hear your experiences with upgrading. If you encounter any issues or have feedback, please don’t hesitate to respond here, open a new issue, or submit a pull request. Your contributions are always welcomed and valued!

kettanaito commented 10 months ago

Thank you for your incredible work on this, @valendres! 👏

thraizz commented 10 months ago

@valendres should this issue be closed as the migration is done? Currently, it looks like the migration is still open. Thanks for your work! 😸

chrisb2244 commented 8 months ago

@valendres - although it's not really a "real-world" case yet, this library (at v3.0.1) worked well for me with Playwright and handlers created using MSW's http.get function to test a client-side fetch in a Next.js example repo (https://github.com/chrisb2244/msw-nextjs-example).

Thanks for the library!