search

valendres / playwright-msw

A Mock Service Worker API for Playwright
MIT License
162 stars 22 forks source link

feat: add support for MSW 2.x #77

Closed valendres closed 9 months ago

valendres commented 10 months ago

This PR adds support for MSW 2.x, which is a breaking change. Consumers will be required to upgrade to MSW 2.x when installing playwright-msw v3. https://mswjs.io/docs/migrations/1.x-to-2.x

kettanaito commented 10 months ago

I may be wrong about this but it looks like you need to git-ignore the .yarn directory.

the-ult commented 10 months ago

I may be wrong about this but it looks like you need to git-ignore the .yarn directory.

Was thinking the same thing

valendres commented 10 months ago

Thanks for the awesome feedback everyone. I've been a bit pressed for time these last few days, but I'll do my best to resolve everything ASAP.

hnrq commented 9 months ago

Awesome! Looking forward to this!

valendres commented 9 months ago

I may be wrong about this but it looks like you need to git-ignore the .yarn directory.

@the-ult @kettanaito this project is using yarn berry with zero-installs. With this feature enabled, it's intended that .yarn/cache is not git ignored. While it makes git clones and branch switching a lot faster, it makes code review a lot more challenging and creates some very understandable confusion. I'm going to disable this feature and rebase the PR to get rid of the unnecessarily large change set.

valendres commented 9 months ago

Hey everyone,

Just a quick update on v2 support: my goal for tonight is to finalize and merge the PR, followed by a release. šŸš€

I want to extend a special thanks to @the-ult and @kettanaito for your thorough reviews, and a huge shoutout to @mamidenn for proactively addressing all the feedback. Your contributions are invaluable and greatly appreciated.

I apologize for the recent delay. Between preparing for a house move, last-minute renovations for sale of the current house, and attending AWS re:INVENT, time has been particularly tight. However, now that re:INVENT has concluded and my preparations are nearly complete, Iā€™m excited to refocus on the library.

Thank you for the patience :)

the-ult commented 9 months ago

@valendres thanks you for your awesome work. Really happy with the update, can't wait to use it. šŸ‘šŸ¼

These are busy times, so super happy you were able time make some time