Suggestions and comments

[willcastillo]

Hey, thanks for this plugin.

I have a suggestion:

• It'd be great if the literals Undo, Redo, Download, etc., are translatable. Actually, it'd be great if the buttons are customizable by the consumer (like, using just icons, for instance, same with their positions.)

A couple of comments:

• While setting the height to 350, I noticed the width overflows to its right:
• The download option is not reliable. Probably it'd be better to dispatch an event with the data and handle the download from the backend?

And a question:

• I added a sketchpad to a dynamically created form which stores its its data in a json object. The sketchpad's stroke property is empty though. Like this:

  {"free-draw":"{\"width\":1655,\"height\":350,\"strokes\":[],\"undoHistory\":[]}"}

(free-draw is the name of my field.)

Any idea what am I doing wrong?

[valentin-morice]

Hi, thanks for the feedback. Good suggestion regarding button labels, I'll include those changes in the next release. Regarding your issue, do you think you could provide a reproduction repository, or at least the code generating your form?

[willcastillo]

Sure. Nothing fancy to be honest. As I said, it is dynamically generated but this is the portion that renders the field:

protected function getSketchpadComponent($field_id, $data): Component
    {
        return FilamentSketchpad::make($field_id)
            ->label($data['label'])
            ->height($data['height'])

            ->hint($data['hint'])
            ->helperText($data['helper'])

            ->columnSpan($data['columns-used']);
    }