valentinacupac / banking-kata-java

Banking Kata (Java)
MIT License
336 stars 90 forks source link

Adapter - Messaging - RabbitMQ - receiveAndConvert #118

Open valentinacupac opened 1 year ago

valentinacupac commented 1 year ago
          Hello @eamtalu! I have one suggestion; you can add `receiveAndConvert("default-bankingkata-queue");` after the publishing method and verify with AssertJ that way:
rabbitMQEventBus.publish(accountOpenedDto);

Object message = rabbitTemplate.receiveAndConvert("default-bankingkata-queue");

Assertions.assertThat(message).isEqualTo(accountOpenedDto);

I think it will work fine.

_Originally posted by @JoaoCipriano in https://github.com/valentinacupac/banking-kata-java/pull/117#discussion_r1227428620_

valentinacupac commented 1 year ago

@eamtalu feel free to consider this.

eamtalu commented 1 year ago

Hi @valentinacupac, sure I will work on this. @JoaoCipriano Thanks for code review, appreciate it. Reg, Amin