And then classes FakeNationalIdentityProviderGiven and FakeNationalIdentityProviderGivens...
Need to think about consolidation...
Improvement 2
Perhaps there could be default time & fake number setup to handle tests that don't care about it? And then can override in tests which actually do care about it.
Improvement 1
In OpenAccountUseCaseTest, there are repetitive lines of code regarding
givenThat
And then classes
FakeNationalIdentityProviderGiven
andFakeNationalIdentityProviderGivens
...Need to think about consolidation...
Improvement 2
Perhaps there could be default time & fake number setup to handle tests that don't care about it? And then can override in tests which actually do care about it.
Improvement 3
The FakeGenerator can be tested once, in the base.
Improvement 4
Replace
given
bysetup