search

valentinajemuovic / banking-kata-java

Banking Kata (Java)
MIT License
346 stars 92 forks source link

GitHub - Fix SonarQube #123

Open valentinajemuovic opened 1 year ago

valentinajemuovic commented 1 year ago

I had disabled SonarQube, pending to resolve the warnings then I will re-enable it.

KalinIvanov-l commented 1 year ago

Hi,

I am interested in working on resolving the SonarQube warnings to help re-enable it on the project. Could you please reassign this ticket to me so I can start working on it?

Best regards, Kalin

valentinajemuovic commented 1 year ago

Thanks @KalinIvanov-l, assigned now.

valentinajemuovic commented 10 months ago

Thanks for your help @KalinIvanov-l! I merged the PR https://github.com/valentinacupac/banking-kata-java/pull/126

However, as CI ran, some errors appeared, you can see here https://github.com/valentinacupac/banking-kata-java/actions - I tried some attempts to fix it, but wasn't able to get it working after the merge. You can have a look at that output to see if you have any ideas for the fixing the failing tests, or otherwise I may also continue to look at this during the next days...

Thanks again for your support.

KalinIvanov-l commented 10 months ago

Hi,

Thank you for your feedback. I'll review the error and work on resolving it, which should rectify the issue in CI. I'll inform you as soon as I'm ready.

Thanks again!

valentinajemuovic commented 10 months ago

Thank you very much!

valentinajemuovic commented 10 months ago

P.S. I've now reset the main branch to my earlier commit (i.e. before merging the PR) so that the CI pipeline is green. So you can continue working on the PR to try to get the tests passing and then after you've locally tested, then we can try to merge the PR again.