search

valentineap / ComputationalGeoscienceCourse

Materials for an introductory course in Python programming for geoscientists
7 stars 1 forks source link

Milankovitch practical ready for review #6

Closed valentineap closed 5 years ago

valentineap commented 6 years ago

https://github.com/valentineap/ComputationalGeoscienceCourse/tree/master/Practicals/Exercise%20N%20-%20Fourier%20analysis

Note that 'sealevel.py' contains code to solve most of this practical, but which isn't actually called within the jupyter notebook.

Oscar, feel free to add stuff!

charlesll commented 6 years ago

I did the entire exercise, very good. I only did a minor modification as it is a bit confusing at first to have the power spectrum with frequencies in X. I just indicated that period = 1/f.

valentineap commented 6 years ago

Another out-of-sequence assignment to prevent @rmcgirr94 from getting bored... :-)

oscarbranson commented 6 years ago

Looks good. Perhaps add a de-trending step, instead of/as well as 'subtract the mean'?

rebecca-mcgirr commented 5 years ago

Finished testing, closing issue.