search

valentineap / pyprop8

A lightweight Python code to calculate the seismic response of a layered half-space (including static components), and derivatives of the wavefield wrt source components.
GNU General Public License v3.0
25 stars 5 forks source link

Clarify paper #12

Closed valentineap closed 2 years ago

valentineap commented 2 years ago

Comment from @hfmark in openjournals/joss-reviews#4217:

When you say that "The computational approach described by O'Toole and Woodhouse (2011) (but not the pyprop8 implementation)" has been used for these things, does that mean that pyprop8 is implementing a simplified version of the O'Toole and Woodhouse formulation, or just that the original prop8 was used instead of this particular code? I'm guessing the latter, but given how strongly the Statement of need emphasizes teaching/outreach uses rather than research, it would be good to clarify that the methodology is fully implemented and the fact that it's easy to use is a nice bonus.

valentineap commented 2 years ago

I've rephrased this bit of the paper. I believe pyprop8 implements everything from the O'Toole et al. papers. I've also added a nice figure!