search

valentjn / ltex-ls

LTeX Language Server: LSP language server for LanguageTool :mag::heavy_check_mark: with support for LaTeX :mortar_board:, Markdown :pencil:, and others
https://valentjn.github.io/ltex
Mozilla Public License 2.0
791 stars 38 forks source link

ltex with vim, Can I add some words to the dictionary inside vim #182

Open jonggyup opened 2 years ago

jonggyup commented 2 years ago

I am using ltex with vim now.

But some words are not in the dictionary but are not wrong.

LTex keeps showing that those words are wrong, and that's annoying.

Can I add such words into the dictionary while I am using vim?

We can do similar things by clicking a with set spell, I guess. But idk how to do with ltex.

Thank you

paperbenni commented 2 years ago

There is a code action to add words to the dictionary. For some reason it doesn't work tough

coffebar commented 2 years ago

Is it will be fixed? I can help with testing

paperbenni commented 2 years ago

Someone made a plugin to fix this #171 I really am not sure why this is needed though, I haven't looked into the lsp implementation of neovim but it shouldn't be too hard to tell the lsp which code action you chose, which in theory should be all that's needed for the lsp to do the dictionary actions itself. Maybe right now the editor needs to implement the dictionary itself, but it should be possible to have an lsp that does it

coffebar commented 2 years ago

May be this is a solution vigoux/ltex-ls.nvim So this is not a problem of ltex-ls. rather neovim/nvim-lspconfig

paperbenni commented 2 years ago

From the looks of it vigoux/ltex-ls.nvim goes way beyond the scope of what lspconfig is supposed to do. From what I can tell by glancing over it this also implements some dictionary functionality that is for some reason not provided by either languagetool, ltex-ls or nvim-lsp

paperbenni commented 2 years ago

seems like ltex-ls uses off spec commands https://github.com/neovim/nvim-lspconfig/issues/1443#issuecomment-972863557 This would have to be implemented into the lsp client or the server has to stop using them. In my opinion diverging from the spec should be an absolute last resort as it kind of defeats the purpose of it being an lsp. Now maybe ltex-ls has good reasons for doing so as the lsp spec wasn't made with non-programming languages in mind, but I would really love if a workaround could be found. Everyone adding random extensions to the protocol would be really bad for the ecosystem