tobiscode
commented
1 month ago Same issue here. Thanks for the pointer, never coded JS before but I was able to fix my local installation with the following changes to extension.js:
--- a/extension.js.old
+++ b/extension.js
@@ -13516,6 +13516,7 @@ class DependencyManager {
const executableOptions = {
encoding: 'utf-8',
timeout: 15000,
+ shell: true
};
if (executable.options != null) {
executableOptions.cwd = executable.options.cwd;
@@ -13615,6 +13616,7 @@ class DependencyManager {
const executableOptions = {
encoding: 'utf-8',
timeout: 15000,
+ shell: true
};
const childProcess = ((process.platform == 'win32')
? ChildProcess.spawnSync('wmic', ['process', 'list', 'FULL'], executableOptions)
@@ -24684,7 +24686,9 @@ class LanguageClient extends commonClient_1.CommonLanguageClient {
if (node.args) {
node.args.forEach(element => args.push(element));
}
- const execOptions = Object.create(null);
+ const execOptions = {
+ shell: true
+ };
execOptions.cwd = serverWorkingDir;
execOptions.env = getEnvironment(options.env, false);
const runtime = this._getRuntimePath(node.runtime, serverWorkingDir);
@@ -24817,6 +24821,7 @@ class LanguageClient extends commonClient_1.CommonLanguageClient {
let args = command.args || [];
let options = Object.assign({}, command.options);
options.cwd = options.cwd || serverWorkingDir;
+ options.shell = true;
let serverProcess = cp.spawn(command.command, args, options);
if (!serverProcess || !serverProcess.pid) {
return Promise.reject(`Launching server using command ${command.command} failed.`);I'm hoping this will work until the package is properly patched.
pyromanul
Saltsmart
peiranxiao
Berrysoft
sp1337dy
thangckt
FeudalFreddy
rtbar
olejorik
georgiiv123
NegInfinity
Schranke95
JonathanJPerry
JakeSteam
EReis0
Samuluo
RobuxShooters
richetl
Uchiha-Senju
spitzerd
divenex
Foadsf
veronidan
Describe the bug New versions of Node require setting "shell: true" when calling spawn/spawnSync on a .bat file such as "ltex-ls.bat".
Steps to reproduce Run on Windows.
Expected behavior That it works.
Sample document N/A
LTeX configuration N/A
"LTeX Language Server" log file No log file created as server never starts
"LTeX Language Client" log file 2024-07-29T17:17:28.190Z Info: Setting LTeX UI language to 'en'. 2024-07-29T17:17:28.190Z Info: Loading i18n messages... 2024-07-29T17:17:28.190Z Info: Loading default i18n messages... 2024-07-29T17:17:28.194Z Info: 2024-07-29T17:17:28.194Z Info: ltex.ltex-ls.path not set. 2024-07-29T17:17:28.194Z Info: Searching for ltex-ls in 'c:\Users...'... 2024-07-29T17:17:28.194Z Info: ltex-ls found in 'c:\Users...'. 2024-07-29T17:17:28.194Z Info: 2024-07-29T17:17:28.194Z Info: Using ltex-ls from 'c:\Users...'. 2024-07-29T17:17:28.194Z Info: Using Java bundled with ltex-ls as ltex.java.path is not set. 2024-07-29T17:17:28.196Z Info: Testing ltex-ls... 2024-07-29T17:17:28.196Z Info: Command: "c:\Users\...\lib\ltex-ls-15.2.0\bin\ltex-ls.bat" 2024-07-29T17:17:28.196Z Info: Arguments: ["--version"] 2024-07-29T17:17:28.196Z Info: env['JAVA_HOME']: undefined 2024-07-29T17:17:28.196Z Info: env['JAVA_OPTS']: "-Xms64m -Xmx512m" 2024-07-29T17:17:28.196Z Error: Test failed. 2024-07-29T17:17:28.196Z Error: Error details: 2024-07-29T17:17:28.201Z Error: Error: spawnSync c:\Users...\lib\ltex-ls-15.2.0\bin\ltex-ls.bat EINVAL 2024-07-29T17:17:28.201Z Error: at Object.spawnSync (node:internal/child_process:1124:20) 2024-07-29T17:17:28.201Z Error: at Object.spawnSync (node:child_process:914:24) 2024-07-29T17:17:28.201Z Error: at DependencyManager. (c:\Users...\dist\extension.js:15912:43)
2024-07-29T17:17:28.201Z Error: at Generator.next ()
2024-07-29T17:17:28.201Z Error: at fulfilled (c:\Users...\dist\extension.js:15367:32)
2024-07-29T17:17:28.202Z Info: ltex-ls did not print expected version information to stdout.
2024-07-29T17:17:28.202Z Info: stdout of ltex-ls:
2024-07-29T17:17:28.202Z Info:
2024-07-29T17:17:28.202Z Info: stderr of ltex-ls:
2024-07-29T17:17:28.202Z Info:
2024-07-29T17:17:28.202Z Info: You might want to try offline installation, see https://valentjn.github.io/vscode-ltex/docs/installation-and-usage.html#offline-installation.
Version information
Additional context/information Easy enough to solve by patching extension.js file locally. See https://github.com/node-red/node-red/pull/4652/commits/bd58431603fb4169c1696f6b97a618b1acae5091 for pattern to fix. Will submit PR if this project is active and accepting PRs.