search

valentsea / draggable-resizable-vue3

Vue 3 component for draggable and resizable elements.
https://draggable-resizable-vue3.netlify.app/
MIT License
30 stars 6 forks source link

Unmounting is not correctly handled #2

Open ajmcgrail opened 1 week ago

ajmcgrail commented 1 week ago

I have added a test case here https://codesandbox.io/p/devbox/wild-wood-wfwxtn?workspaceId=4b08d1d7-1230-40b3-8d2d-b2981bb1e67f for convenience based off the README. To reproduce the problem, simply click the button that says HERE so that the draggable component is unmounted, and then after that adjust the size of the window in the editor (so that the screen is resized. There should be numerous errors that look like this: image

This can be addressed with a change in DraggableResizableVue3.vue by adding 

onUnmounted(() => {
  removeEvent(document.documentElement, 'mousedown', deselect)
  removeEvent(document.documentElement, 'touchend touchcancel', deselect)
  removeEvent(window, 'resize', checkParentSize)
})

to the component, although I do not know if it's a perfect solution.

ajmcgrail commented 1 week ago

A CodeSandbox is here https://codesandbox.io/p/devbox/laughing-mclaren-ttqs6z?workspaceId=4b08d1d7-1230-40b3-8d2d-b2981bb1e67f using my fork here https://github.com/ajmcgrail/draggable-resizable-vue3/tree/ajmcgrail-patch-1 which shows the error no longer happening (though I'm not saying everything is correctly handled on unmount).