search

valeriangalliat / fetch-cookie

Decorator for a `fetch` function to support automatic cookie storage and population. 🍪
The Unlicense
135 stars 29 forks source link

Set minimum version of tough-cookie to 2.3.3 #37

Closed wrumsby closed 5 years ago

wrumsby commented 5 years ago

Modify package.json to ensure the minimum version of tough-cookie is 2.3.3.

v2.3.3 includes salesforce/tough-cookie#97 which addresses a ReDOS vulnerability.

Also modified test.js because the use of notProperty seemed incorrect and tests were failing - see #36.

cc @FabianTe

fabiante commented 5 years ago

Looks good to me!

@valeriangalliat Are you going to merge and publish this to NPM or shall I do the honor? 😉

valeriangalliat commented 5 years ago

@FabianTe please be my guest, as I'm pretty much offline for the next two weeks 😋

On Fri., Jun. 21, 2019, 04:02 Fabian Te, notifications@github.com wrote:

Looks good to me!

@valeriangalliat https://github.com/valeriangalliat Are you going to merge and publish this to NPM or shall I do the honor? 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/valeriangalliat/fetch-cookie/pull/37?email_source=notifications&email_token=AA57ILMZPVKOQPBV4J4O4NTP3SDLBA5CNFSM4HWB5IWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYHYDSI#issuecomment-504332745, or mute the thread https://github.com/notifications/unsubscribe-auth/AA57ILM3GMU4DXTEZTRAMMTP3SDLBANCNFSM4HWB5IWA .

fabiante commented 5 years ago

Will do next monday / tuesday.