Hashtable dependency does not build correctly when using "Yarn add"

valeriansaliou / node-fast-ratelimit

:umbrella: Fast and efficient in-memory rate-limit for Node, used to alleviate most common DOS attacks.

https://www.npmjs.com/package/fast-ratelimit

MIT License

108 stars 19 forks source link

Closed wdmtech closed 7 years ago

wdmtech commented 7 years ago

Just noting this in case someone else tries it!

valeriansaliou commented 7 years ago

I do accept PRs 🙂

wdmtech commented 7 years ago

I'm not sure if it's because it was compiled on Windows - I'll check on my mac tomorrow.

simlu commented 7 years ago

Same here. Does not seem to work on windows unfortunately...

simlu commented 7 years ago

Finally fixed this by installing npm install -g windows-build-tools with elevated privileges (Reference https://superuser.com/questions/1032689/how-do-i-add-vcbuild-exe-to-windows-10-w-o-visual-studio)

simlu commented 7 years ago

Would you mind adding that to the docs please?

Also I'm getting some warnings, but will post as separate issue.

valeriansaliou commented 7 years ago

Added to the README, thanks!