Hashmap doesn't seem to get uninstalled correct

valeriansaliou / node-fast-ratelimit

:umbrella: Fast and efficient in-memory rate-limit for Node, used to alleviate most common DOS attacks.

https://www.npmjs.com/package/fast-ratelimit

MIT License

108 stars 19 forks source link

Hashmap doesn't seem to get uninstalled correct #5

Closed simlu closed 3 years ago

simlu commented 7 years ago

An empty folder remains for some reason. Maybe this is expected for native dependencies?

valeriansaliou commented 7 years ago

Can I have more info. on this?

simlu commented 7 years ago

Sure! (1) npm install fast-ratelimit (2) run code using the ratelimiter (3) npm uninstall fast-ratelimit

The hashtable folder does not get cleaned up completely in this case. I'm wondering if some files can not be deleted b/c they are loaded by windows.

Might not be related to you project but just a general observation.

valeriansaliou commented 3 years ago

Hello there! I've fixed that in v3.0.0, using the JS-native Map object, which has as well be measured in my tests to be faster anyway. This new version does not compile any dependencies anymore, fixing this issue.