search

valeriansaliou / node-sales-tax

:moneybag: International sales tax calculator for Node (offline, but provides optional online VAT number fraud check). Tax rates are kept up-to-date.
https://www.npmjs.com/package/sales-tax
MIT License
299 stars 45 forks source link

remove 'request' module since it is deprecated and on maintenance period #52

Closed wootra closed 1 year ago

wootra commented 1 year ago

relative article : https://github.com/request/request/issues/3142

my project is using node-sales-tax, but it has deprecation warning. I tried to see what it is and soon realized that it is pretty serious. Since it is just a simple change, I think it is better for me to update myself. And it is even better to share with people since it is a great npm module!

valeriansaliou commented 1 year ago

Thank you for the MR. Could you restrict the changes to the request migration strictly, w/o changing the test pipeline? This could be part of another MR, but I'd like to keep the changes minimal.

wootra commented 1 year ago

istanbul is deprecated. I tried to run test with minimal change ( only node-fetch ), but test does not even work. mocha version is extremly outdated. Not sure if this test will pass the pipeline.

edit: pnpm and yarn does not work testing, but npm is working. trying to make it work.

wootra commented 1 year ago

since I made 2 different MR, I'll close this.