search

valeriansaliou / vigil

🚦 Microservices Status Page. Monitors a distributed infrastructure and sends alerts (Slack, SMS, etc.).
https://crates.io/crates/vigil-server
Mozilla Public License 2.0
1.72k stars 128 forks source link

Show replica name in tooltip when hovering replica item (opt-in option) #53

Closed blissend closed 1 year ago

blissend commented 4 years ago

First of all, thanks so much for vigil. I have tried so many alternatives and vigil is the only one that works consistently and works best.

I do have a feature request however. It would be nice to be able to mark or show somehow which replica's is which on the web page. Doesn't have to give away sensitive info, could be a label or anything really.

If this is by design let me know or already possible then just ignore me :D I think it may be useful sometimes to know in automated workflows what got added/removed or perhaps you don't want to alert but curious which replica has unusual latency (which I'm not sure why some replica's show latency and others none in that popup).

valeriansaliou commented 4 years ago

Hello there,

I'm currently not showing the replica name on the public Web page, as it could reveal which internal IP address or URL is being probed. I could add an option to toggle this on or off, with a default value set to "don't show replica name".

Would that do?

blissend commented 4 years ago

Understood. That would do it for me at least.

Would it make sense to allow each replica to have an optional label? So if I called replica 2 BlueWhale only those who know internally would understand.

valeriansaliou commented 4 years ago

That would make sense as well, let's go for that. On it.

richnusgeeks commented 4 years ago

+1 as looking for the clue which underlying server/alias/label (in order of preference) is failing the test. FYI I'm using the status page for within company only runtime acceptance testing endpoint baked into those VMs (ranging from few to hundreds grouped into their respective categories through probe.service sections).

verymilan commented 3 years ago

I am confused... this milestone is done for a while now, doc seems not to mention that and commits around that time are not very descriptive..

valeriansaliou commented 3 years ago

This is not yet implemented.

verymilan commented 3 years ago

Thanks for letting me know :)

gbonnefille commented 3 years ago

What about setting the label in the URL, using the fragment part of the URL like http://...#my_label? It could be use also for other URI, like ICMP or other.

As far as I know, the fragment part is not processed by server, but only by client. So, using it as a storage for label will never handicap some user to refer an existing service.

https://datatracker.ietf.org/doc/html/rfc3986#section-3.5

erwandf commented 1 year ago

Hi Valerian, is there any update on this issue ? this would also be really useful for us.

Best regards,

valeriansaliou commented 1 year ago

Hey Erwan, thank you for the heads up! Given the interest into this feature, I'll be looking into it today/tomorrow :)

erwandf commented 1 year ago

Thanks, this is very nice of you !