search

valeriansaliou / vigil

🚦 Microservices Status Page. Monitors a distributed infrastructure and sends alerts (Slack, SMS, etc.).
https://crates.io/crates/vigil-server
Mozilla Public License 2.0
1.72k stars 128 forks source link

Support for stable rust #71

Closed tglman closed 3 years ago

tglman commented 3 years ago

Hi,

To build and run vigil is required nigthly rust, in many case this is fine but in some stable rust is required. I did my own investigation, and the only reason why nighlty is required is for some compiler features that rocket requires, this should be fixed the next releases of rocket as the master of rocket is already compatible with stable rust: https://github.com/SergioBenitez/Rocket/issues/19#issuecomment-736637259 but this as today is yet not a good option, simply because this is not releases yet.

So i went a bit ahead and made a quick fork (here) that make rocket optional, and then i did a server implementation using actix-web, that as i write it already run in rust stable (you can see the implementation here).

What it's your take on this issue ? do you prefer wait for rocket to be stable ? do you like to have two possible server implementations? or maybe migrate to actix-web is already stable ?

Regards

valeriansaliou commented 3 years ago

Hello @tglman

Thanks a ton for your work on migrating from Rocket to Actix! I was indeed waiting for Rocket to compile on stable, but this takes a bit of time, so I'm willing to fully migrate to Actix.

You may completely remove Rocket in your fork, and submit a PR, I'll greatly appreciate it 👍

Thanks again!

tglman commented 3 years ago

Hi,

Here the PR with rocket that is replaced by actix-web: https://github.com/valeriansaliou/vigil/pull/72

Regards

valeriansaliou commented 3 years ago

Merged