search

valeriobelli / gh-milestone

GitHub CLI extension for managing Milestones
MIT License
54 stars 2 forks source link

Milestone Commands return with Bad Credentials #6

Closed ndrone-kr closed 2 years ago

ndrone-kr commented 2 years ago

Description When doing an edit or create. I get a return of bad credentials.

Current behavior When doing an edit or create. I get a return of bad credentials.

Expected behavior I expect them to create or edit like I can in the UI

Environment:

Additional information I'm able to edit and create in the UI.

valeriobelli commented 2 years ago

Hey @ndrone-kr, thanks for having reported this problem and sorry for the delayed answer. GitHub hasn't notified me.

Sadly, I can't reproduce.

Before going forward with some other debugging, may you try checking your authentication status by running gh auth status? It would be awesome. 😄

valeriobelli commented 2 years ago

Is there any chance your instance is relying only on gh authentication system? I'm saying so because this extension needs GITHUB_TOKEN to do some authenticated calls to GitHub APIs.

ndrone-kr commented 2 years ago

here is the result from the gh auth status

 » gh auth status 
github.com
  ✓ Logged in to github.com as ndrone-kr (/Users/ndrone-kr/.config/gh/hosts.yml)
  ✓ Git operations for github.com configured to use https protocol.
  ✓ Token: *******************

yes I'm relying on gh to handle all the authentication

valeriobelli commented 2 years ago

I released a new version yesterday without opening a Pull Request, sorry 😅 Now, this extension relies on gh to authenticate the current user if environment variables don't include GITHUB_TOKEN.

Could you give it a shot now?

ndrone-kr commented 2 years ago

This now works with the latest release 0.5.1

Thanks for the fix!

valeriobelli commented 2 years ago

You're welcome!