valerionew / ht1621-7-seg

arduino library for 7-segment lcd based on ht1621 drivers
Other
19 stars 13 forks source link

String printing #11

Closed valerionew closed 3 years ago

valerionew commented 4 years ago

Since a 7 segment display can print non-number characters, a print(char*symbols) or a print(String symbols) should be implemented. Possible symbols to be printed are:

Missing alphabet characters: K, M, V, W, X, (Z?)

pk commented 3 years ago

Hi Valerio, I think I've started with the implementation, so I'd like to take this one. I make the fork and we can discuss the solution.

valerionew commented 3 years ago

Sure, thanks! Let me know if you need anything

pk commented 3 years ago

Hi Valerio, have a look at the implementation (I'm not that proficient in C) of the character dipsplay. I've created also KitchenSink sketch to have sll options rendered.

I've implemented rendering of the characters above as well as the numbers. So I can easily print things like 123(deg symbol) and so on.

Let me know what you think, I'm not sure how to better implement Character -> Seg map than what I did.

https://github.com/pk/ht1621-7-seg

valerionew commented 3 years ago

Looks good, i left a couple of comments on your code.

I don't think there are many other ways to map characters to segments, we should rely on compiler's optimization procedures

When you think it's ready open the PR