search

valerionew / unisolder-notes

Markdown documentation repo for building and chosing parts for Unisolder, the open source universal soldering iron controller
Creative Commons Attribution 4.0 International
202 stars 46 forks source link

Updating README.md #38

Closed wildstar87 closed 8 months ago

wildstar87 commented 8 months ago

Added Rotary Encoder information, made FAN5331 replacement a little clearer.

wildstar87 commented 8 months ago

Not sure if I did this right..

valerionew commented 8 months ago

It looks good to me

valerionew commented 8 months ago

This fixes #37

valerionew commented 8 months ago

Thank you for this contribution! It's very useful information 😄

Anytime you want to add something more, now you know how to!

wildstar87 commented 8 months ago

Is it always a requirement to fork before doing a pull request? Or did I add an extra unnecessary step?

From: Valerio @.> Sent: Thursday, November 30, 2023 3:18 PM To: valerionew/unisolder-notes @.> Cc: wildstar87 @.>; Author @.> Subject: Re: [valerionew/unisolder-notes] Updating README.md (PR #38)

Thank you for this contribution! It's very useful information 😄

Anytime you want to add something more, now you know how to!

— Reply to this email directly, view it on GitHubhttps://github.com/valerionew/unisolder-notes/pull/38#issuecomment-1834712290, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM4U4PAYBKBCLEA7MNW35DDYHEH5HAVCNFSM6AAAAABAB6YPS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUG4YTEMRZGA. You are receiving this because you authored the thread.Message ID: @.***>

valerionew commented 8 months ago

If you are making very small changes GitHub allows you to do them without forking. In this case, you did the right thing.

Now that you have a fork of the repo it will stay in your repositories, so there is no need to fork it again when you will have new changes. Just make sure to do a pull request from this repo to yours before making changes so that you always start from the most recent version.