valeriotor / Beyond-The-Veil

A Minecraft Mod inspired by the writings of H.P. Lovecraft, as well as other works based on the author.
Other
14 stars 6 forks source link

Exception in server tick loop When dreaming darkness #44

Open rogo921 opened 3 years ago

rogo921 commented 3 years ago

When i first use this dream to locate the darkness biome its ok. I get a set of x and z position nearby.(In fact only a mountain there) But after i encounter another bug after a server crashing. I switch a new account and try the research again and i encounter another crash. Heres the crashinglog. crash-2021-09-06_21.02.35-server.txt I guess maybe it was because the number of map blocks I explored were huge and it may take much time to research position. But
I increased my server`s max ticking time but it cant work.

thedeerirty commented 3 years ago

Did you progress past this point, and if so did you have any issues?

assasinwar9 commented 3 years ago

can confirm this is a thing still.... and i can no longer log in with that account..... server crashes with the same "dream of darkness" error even if i just started it and joined ..... its very likely a mod conflict as my server log shows more then this mod is messing with onPlayerWakeUp ..... unless its due to someone already having found one of the "coastal villages" as i call them... i found 2 before doing the dream of darkness soooooo ya ...

this is the first server crash log im pretty sure : https://pastebin.com/LyuGpS6N

this is shortly after i started it up again after it crashed and tried to join with my same account : https://pastebin.com/esjy5RPd

annnnnd this is the whole server "latest.log" for that first crash's session .... i had to cut most of it out due to pastebin's limit on size... but it includes a few "loot table" problems etc then gets to the point i was on about with the onPlayerWakeUp .. : https://pastebin.com/vq7uppKN

thedeerirty commented 3 years ago

can confirm this is a thing still.... and i can no longer log in with that account..... server crashes with the same "dream of darkness" error even if i just started it and joined ..... its very likely a mod conflict as my server log shows more then this mod is messing with onPlayerWakeUp ..... unless its due to someone already having found one of the "coastal villages" as i call them... i found 2 before doing the dream of darkness soooooo ya ...

this is the first server crash log im pretty sure : https://pastebin.com/LyuGpS6N

this is shortly after i started it up again after it crashed and tried to join with my same account : https://pastebin.com/esjy5RPd

annnnnd this is the whole server "latest.log" for that first crash's session .... i had to cut most of it out due to pastebin's limit on size... but it includes a few "loot table" problems etc then gets to the point i was on about with the onPlayerWakeUp .. : https://pastebin.com/vq7uppKN

I have found a fix for the crashing, but I believe the issue is caused by some method in which the dream searches for a voided biome, or a terrain generator. I noticed when attempting the dream in newly loaded chunks along the border of unloaded chunks, I could dream just fine.

To fix, have another player break the bed or sleep chamber you have slept in. If you used a bottle though, not sure what to do then.

valeriotor commented 3 years ago

Hey everyone. Sorry for being so inactive lately. Irl stuff, studies and all, are keeping me busy. I haven't been able to reproduce the Dream of Darkness crash, even in multiplayer. Judging from the log the problem happens during the sending of the chat message, weirdly enough, and it may entail a null player connection in EntityPlayerMP. I am really uncertain of what could cause this. That said, I've recently fixed another bug, related to marking researches as updated, as show in commit 2ddb12b498fd76814ad12949ce73245dc755d00b There is a chance that the two bugs could be related, in fact the first log in @assasinwar9's post actually relates to the latter bug, the fixed one. So there is a chance that the fix could also affect the Dream of Darkness itself. I am really not certain about this though. In any case, if anyone of you could try using this modified version of BTV (that includes the latest commits), installing it on both client and server, I would really appreciate it if you told me whether it fixed anything.

assasinwar9 commented 3 years ago

alright iv downloaded that version and will make a copy of both the server and client now, that way i can test without any potential long term problems and if needed i can host the normal server for my friends as they do play it quite a bit atm lol!

ill try my best to let you know if it fixes it etc!

and trust me i understand on getting busy with stuff, especially since im sick atm lol!

assasinwar9 commented 3 years ago

sadly it crashed as i tried to join... and just in case... here is the new crashlog : https://pastebin.com/CcH9kNvp

valeriotor commented 3 years ago

Alright, thanks for testing it though! I'll try to investigate it in the following days. It's very weird that the server's firing the WakeUpEvent as soon as you login. Perhaps we're facing some sort of mod conflict, especially with all those core mods present. I'll see what I can do. (also get well soon :D )

assasinwar9 commented 3 years ago

annnnd i tried dreams of water after logging in with my alt and breaking the bed, fume spreader, and sleep chamber just incase...... well dreams of water did the same thing :(

annnnnd now the book is acting like i havent done the commune and .... all the entries show "progress" despite clearly being done, and ... its broke broke lol

ill try to keep my eye here for now, but ya thats.... kinda a wrap for this atm lol