search

valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Missing geographical regions #103

Closed DrYool closed 1 year ago

DrYool commented 1 year ago

I can't see why, but several large regions are no longer producing output. These are the North Atlantic, North Pacific and South Pacific, but not - weirdly - the South Atlantic. This can be seen in a number of recent jobs, for example:

https://gws-access.jasmin.ac.uk/public/esmeval/CompareReports/bgcval2/ayool/ukesm_oae_rate/#OtherPlots-AirSeaFlux

ledm commented 1 year ago

I'll add these into PR #102 as it already adds several new regions.

ledm commented 1 year ago

The regions I'm including now are:

regions         : Global ignoreInlandSeas SouthernOcean ArcticOcean Equator10 NorthPacificOcean SouthPacificOcean NorthAtlanticOcean  SouthAtlanticOcean

Are these enough?

ledm commented 1 year ago

We can add any regions or cuts from https://github.com/valeriupredoi/bgcval2/blob/main/bgcval2/bgcvaltools/makeMask.py

There are a lot of them!

ledm commented 1 year ago

I see in #104 that you also use OnShelf OffShelf regions. Do you want me to add them in as well? Or just keep them for MLD?

DrYool commented 1 year ago

Hi Lee. I added these specifically for the alkalinity analysis I was doing. I don't know how important they are otherwise. So don't worry about them. Anyway, I can see that some of the other areas I requested are now online, so that's good. Cheers.