valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Mixed layer depth issues #104

Closed DrYool closed 1 year ago

DrYool commented 1 year ago

There seem to be issues with mixed layer depth in current suites. For instance:

https://gws-access.jasmin.ac.uk/public/esmeval/CompareReports/bgcval2/ldemora/TerraFIRMA_overshoot_historical/#OtherPlots-MLD

I previously had trouble with this and resolved it (to a degree) by creating a new diagnostic (mld2.yml) that I've pasted in below.

---
name            : MLD2
units           : m
model           : NEMO
modelgrid       : eORCA1
dimensions      : 2
modelFiles      : $BASEDIR_MODEL/$JOBID/nemo*$JOBIDo_1y_*_grid-T.nc
model_vars      : mlotst
model_convert   : NoChange
layers          : layerless
regions         : Global OnShelf OffShelf ignoreInlandSeas SouthernOcean ArcticOcean Equator10 NorthAtlanticOcean SouthAtlanticOcean NorthPacificOcean SouthPacificOcean #;Remainder NorthernSubpolarAtlantic NorthernSubpolarPacific
ledm commented 1 year ago

We were previously looking at MLD from somxl010 somxzint1. I think that different versions of NEMO output different names. I'd guess we'll have to keep this backwards compatible, so we can't just copy this code in.

DrYool commented 1 year ago

These seem to be working correctly now. One or two region gaps, but I suspect that's just the suite processing lagging. Happy to sign off on this.