valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Add support for Python=3.12 #113

Closed valeriupredoi closed 3 months ago

valeriupredoi commented 9 months ago

Closes #112

~Yeh this needs to wait, bet after Christmas it'll all be dandy~

All dependencies solve for and tests pass - we have full support for Python=3.12 :partying_face:

valeriupredoi commented 8 months ago

gonna revisit imminently, things are a lot smoother Py312-wise now

valeriupredoi commented 6 months ago

as per https://github.com/conda-forge/basemap-feedstock/issues/119 and @molinav 's efforts baemap is now compatible with Python 3.12 - the only problem we now have is nctoolkit

valeriupredoi commented 6 months ago

@robertjwilson and myself are sort of discussing the 3.12 support for nctoolkit in here https://github.com/pmlmodelling/nctoolkit/pull/111 - numba (as a dep for nctoolkit) is the blocker currently

robertjwilson commented 6 months ago

No worries @valeriupredoi . It looks like the release candidate for numba is Python 3.12 ready. However, "Numba is currently on a Winter Break", whatever that means. So just need to wait for them to decide to push a full release to pypi https://github.com/numba/numba/issues/9197

valeriupredoi commented 6 months ago

cheers @robertjwilson - Winter Break sounds a bit scary - Napoleon went on such a venture in Russia and came back without an army, so hopefully they'll be back :grin:

valeriupredoi commented 5 months ago

@robertjwilson good news, mate! numba has finally come back from winter break and some 29 hours ago they finally py312-ed themselves :partying_face:

robertjwilson commented 5 months ago

OK. Just need to wait for the gears to grind at conda-forge for nctoolkit to be available for 3.12, @valeriupredoi. Essentially, we need to wait for their system to automatically re-build geoviews, and then nctoolkit.

valeriupredoi commented 5 months ago

OK. Just need to wait for the gears to grind at conda-forge for nctoolkit to be available for 3.12, @valeriupredoi. Essentially, we need to wait for their system to automatically re-build geoviews, and then nctoolkit.

ya! No rush at all @robertjwilson - we needed numba to be 312-modern for another package, just wanted to drop the good news :grin:

robertjwilson commented 3 months ago

I have finally got nctoolkit available for python 3.12 on conda forge. Let me know if everything works at your end @valeriupredoi and I will close the issue.

valeriupredoi commented 3 months ago

great news @robertjwilson cheers :beer: Let me resurrect this one then

valeriupredoi commented 3 months ago

@ledm give this one a nod of approval pls bud, we are now modern wrt Python :snake:

valeriupredoi commented 3 months ago

no not at all - if tests work then it should be fine. Cheers, bud :beer: And cheers to @robertjwilson for his work on nctoolkit :beer:

robertjwilson commented 3 months ago

Excellent @valeriupredoi