search

valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Added a new subpolar North Atlantic region (SPNA) #127

Closed ledm closed 6 months ago

ledm commented 6 months ago

I'm adding a new subpolar North Atlantic region (SPNA), but while doing so, I found that there's a couple inefficiencies in the data loader.

This patch makes it much more efficient to load data as it now. Previously, if a single region or layer was missing, then all layers and regions were re-loaded. Now it checked whether the full permutation of all (region, layers, metrics) exists, and only loads the missing ones.

BTW, the SPNA is 35 W to 10 W, 40N to 65N. It's an interesting region for climate change! It's going to go into all the default UKESM analyses from now. Currently testing it in Temperature.yml.

This PR requires PR #126 to be completed.

ledm commented 6 months ago

Okay, thanks! Merging.

Now is probably a good time for @DrYool to update his code with the main branch:

git fetch
git merge origin main